Cache schemas by explicit ID in AJV8Validator.isValid #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
evshi
force-pushed
the
evshi/cache-validator
branch
from
f51c234
to
848587b
Compare
evshi
changed the title
|
@heath-freenome updated, PTAL |
There was a problem hiding this comment.
@evshi This looks pretty good! Can you update the CHANGELOG.md and add an 5.8.2 section for this change? And also rebase to main
|
@heath-freenome updated CHANGELOG and confirmed up to date with main |
8 tasks
nickgros
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #3692
For allOf/anyOf schemas, subschemas are compiled each time they are encountered if they lack an $id field. This can create poor performance for large lists or recursive refs. Leveraging the ajv cache to cache subschemas that have been encountered before greatly improves performance.
Checklist
npm run test:updateto update snapshots, if needed.